chore: bump RELAY dependency v1.11.0 -> v2.0.4 (github.com/SoundMatt/RELAY/v2) - #74
Merged
Conversation
…RELAY/v2) go-LIN's go.mod required github.com/SoundMatt/RELAY v1.11.0, three spec versions behind (v1.12, v1.13, v1.14, v2.0 have all shipped since). RELAY v2.0.4 fixed its own go.mod to carry the required /v2 module-path suffix (RELAY#70), so this is the real, current, go-get-able pin. Reviewed every intervening RELAY CHANGELOG entry for LIN-relevant requirement changes: - v1.12: added "c" as a valid CLI `language` value — not applicable, go-lin already reports "go". - v1.13: deep-audit fix pass to RELAY's own conform/interop/crossbar CLI bugs (e.g. --strict silently dropped when placed after the binary path). go-LIN's CI already invokes `relay conform --strict /tmp/go-lin` with --strict first, so it was never exposed to that bug. - v1.14: §13.7.2 module-name registry expansion for RCP/DDS-internals naming drift — RCP/DDS-only, not applicable to LIN. - v2.0 (MAJOR): replaces RCP's canonical types wholesale for real OPEN Alliance TC18 conformance — RCP-only, not applicable to LIN. None of the above required any go-LIN behavioral change. Updated all six `relay "github.com/SoundMatt/RELAY"` imports (adapt.go, adapt_test.go, lin.go, relay_vectors_test.go, cmd/go-lin/main.go, cmd/go-lin/main_test.go) to the /v2 path, removed the old require via `go mod tidy`, and repointed both `.github/workflows/ci.yml` `relay` CLI install pins from v1.11.0 to v2.0.4. Verified against a real v2.0.4 relay CLI built from source: - `relay conform --strict` and `relay interop --strict --protocol LIN` both PASS with no new findings. - The three checked-in testdata/relay-vectors/ LIN golden vectors are byte-identical to RELAY v2.0.4's published spec/vectors/ — no drift. - go build ./..., go vet ./..., go test ./..., go test ./... -race all pass. - gofusa check, gofusa trace -req-coverage 100, gofusa trace -sec-tested 100, gofusa cyber, gofusa vuln all pass with no new findings (pre-existing INFO-level narrowing-conversion notes only, unrelated to this change). Added the v1.5.0 CHANGELOG entry and ROADMAP release-history row per this repo's usual per-release versioning convention (MINOR bump per notable PR). Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
Signed-off-by: Matt <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
go-LIN's
go.modstill requiredgithub.com/SoundMatt/RELAY v1.11.0—three spec versions behind (v1.12, v1.13, v1.14, and the v2.0 MAJOR have
all shipped since). RELAY v2.0.4 fixed its own
go.modto carry the/v2module-path suffix required by Go's semantic import versioningrules (RELAY#70 — without it, v2.0.x was untaggable/uninstallable via
normal
go get/go install). This PR moves go-LIN onto the real,current, installable pin:
github.com/SoundMatt/RELAY/v2 v2.0.4.What changed
go get github.com/SoundMatt/RELAY/v2@v2.0.4, removed the oldgithub.com/SoundMatt/RELAYrequire, rango mod tidy.relay "github.com/SoundMatt/RELAY"imports togithub.com/SoundMatt/RELAY/v2:adapt.go,adapt_test.go,lin.go,relay_vectors_test.go,cmd/go-lin/main.go,cmd/go-lin/main_test.go..github/workflows/ci.ymlrelayCLI install pins(
relay-conform,relay-interopjobs) fromgithub.com/SoundMatt/RELAY/cmd/relay@v1.11.0togithub.com/SoundMatt/RELAY/v2/cmd/relay@v2.0.4.v1.5.0CHANGELOG entry and ROADMAP release-history row,matching this repo's per-release versioning convention.
Conformance review (v1.12 -> v2.0)
Read every intervening RELAY
spec/CHANGELOG.mdentry to check forrequirement changes that could apply to any implementation, not just RCP:
"c"as a valid CLIlanguagevalue. N/A — go-linalready reports
"go".relay conform/interop/crossbarCLI (e.g.--strictsilently droppedwhen placed after the binary path). go-LIN's CI already invokes
relay conform --strict /tmp/go-linwith--strictfirst, so it wasnever exposed to that bug.
internal-package naming drift. RCP/DDS-only, N/A to LIN.
OPEN Alliance TC18 conformance. RCP-only, N/A to LIN. The only part of
v2.0.x relevant to every RELAY consumer was v2.0.4's own fix (the
/v2module-path suffix), which is exactly what this PR picks up.Conclusion: no LIN-relevant behavioral change required. Verified
this for real rather than assuming it:
relayCLI from source and ran it against thebuilt
go-linbinary:relay conform --strictandrelay interop --strict --protocol LINboth PASS, no new findings.testdata/relay-vectors/LIN goldenvectors against RELAY v2.0.4's published
spec/vectors/— byte-identical, no drift.
lin.SpecVersion(aliased fromrelay.SpecVersion) now reports"2.0"automatically; no other spec-version literals needed updating.Test plan
go build ./...go vet ./...go test ./...go test ./... -racerelay conform --strict(RELAY v2.0.4 CLI, built from source) — PASSrelay interop --strict --protocol LIN(RELAY v2.0.4 CLI) — PASSgofusa check— no findingsgofusa trace -req-coverage 100— 100% (123/123)gofusa trace -sec-tested 100— 100% (123/123)gofusa cyber— 0 error/warning (28 pre-existing INFO-levelnarrowing-conversion notes, unrelated to this change)
gofusa vuln— 0 findingsexercises the updated CI pins for the first time in-pipeline